Open
Conversation
added 3 commits
February 11, 2026 19:41
YoniKiriaty
requested changes
Feb 12, 2026
apps/scouting/frontend/src/scouter/hooks/usePositionRecording.ts
Outdated
Show resolved
Hide resolved
apps/scouting/frontend/src/scouter/hooks/usePositionRecording.ts
Outdated
Show resolved
Hide resolved
YoniKiriaty
approved these changes
Feb 12, 2026
karnishein
requested changes
Feb 15, 2026
| * @param sections consists of sections that contains a list of timestamps in ms | ||
| * @returns mean ball amount | ||
| */ | ||
| /** Recursively calculates mean ball amount from timestamp sections. */ |
Contributor
There was a problem hiding this comment.
why did you delete this? I think it is helpfull
Contributor
There was a problem hiding this comment.
ye agreed, this one should stay since its not necesarily obvious what the sections are
| ): { | ||
| recordedPositionsRef: { current: Point[] }; | ||
| start: () => void; | ||
| stop: () => void; |
Contributor
There was a problem hiding this comment.
consider defining an interface for this
| setMovement={(value) => { | ||
| setForm((prevForm) => ({ | ||
| ...prevForm, | ||
| // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.