Skip to content

limelight-recorder#6

Open
emmr253 wants to merge 6 commits intomasterfrom
gb-limelight-recorder
Open

limelight-recorder#6
emmr253 wants to merge 6 commits intomasterfrom
gb-limelight-recorder

Conversation

@emmr253
Copy link

@emmr253 emmr253 commented Dec 10, 2025

No description provided.

Check failure

Code scanning / ESLint

Require any function or method that returns a Promise to be marked async Error

Functions that return promises must be async.

Check failure

Code scanning / ESLint

Enforce typing arguments in Promise rejection callbacks as `unknown` Error

Prefer the safe : unknown for a catch callback variable.
Comment on lines 21 to 30

Check failure

Code scanning / ESLint

Disallow Promises in places not designed to handle them Error

Promise returned in function argument where a void return was expected.

const app = express();
const port = 5000;
app.use(cors());

Check warning

Code scanning / ESLint

Disallow calling a value with type `any` Warning

Unsafe call of a(n) error type typed value.

Check warning

Code scanning / ESLint

Require explicit return and argument types on exported functions' and classes' public class methods Warning

Missing return type on function.

Check warning

Code scanning / ESLint

Disallow non-null assertions using the `!` postfix operator Warning

Forbidden non-null assertion.

Check warning

Code scanning / ESLint

Disallow non-null assertions using the `!` postfix operator Warning

Forbidden non-null assertion.
@Kovler10 Kovler10 changed the title doesn't run but good enough for now limelight-recorder Dec 14, 2025
Copy link
Contributor

@YoniKiriaty YoniKiriaty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Comment on lines 18 to 28
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider moving this too

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that goes with the whole finding where to save videos thing

@YoniKiriaty YoniKiriaty added the project-init A PR to start off a project label Dec 24, 2025
Comment on lines 7 to 21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't use classes if u can (backed by yoni)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

project-init A PR to start off a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments