tests: add queue and begin-time check in ephemeral cluster #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
2 times, most recently
from
7962910 to
a14c6e5
Compare
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
from
e3af680 to
b00ce73
Compare
abhidg
requested review from
andreww,
colinsauze,
sadielbartholomew and
tonymugen
andreww
requested changes
Sep 1, 2025
Collaborator
andreww
left a comment
andreww
left a comment
There was a problem hiding this comment.
Looks good to me, my main comment is that I think we need to make sure it runs if the cats code gets updated. Assuming that's the intention.
Otherwise, just some questions (and note that I'm not a Docker expert, so probably worth getting somebody else to glance at this too).
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
2 times, most recently
from
2d6841e to
5f1738a
Compare
abhidg
force-pushed
the
155-ephemeral-cluster-tests
branch
from
5f1738a to
ecd3fd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #155