Added more Noda Time tool methods #65
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now it just forwards calls to DateTimeTools.
And added dependency on iCal.NET library.
Modified ParsedLine classes to use explicit member implementation when possible. Also reformatted code.
There was no way for client code to use it, and its code was exactly duplicated in TextBasedTabularDataParser.buildColumnHeadersToIndexesDictionary.
It's now parseLine and just returns field data, which reduces duplication in implementations.
Removed unnecessary members and reformatted.
Fixed nullability warnings and reformatted.
Fixed nullability warnings and reformatted.
Fixes some nullability warnings.
Backported improvements from last commit into TextBasedTabularDataParser and TextBasedParsedLine.
In preparation for a new, public ValidationResult class that will be returned by all the Validator methods.
Restructured and simplified underlying validation methods in Validator. They now return the error, set the value via a setter parameter, and no longer trim or check for empty.
This hasn't been used in years, or even decades.
This code is tested and already in use by EWL.
PatternString enables specialized search controls in EWL and provides a good place to support wildcard characters in the future.
This has been in use by EWL for years.
Support for these was added in C# 7.3 in 2018.
Added IsBetween and MonthBeginDate.
This is existing code from EWL, but recently improved based on the listed Stack Overflow answer.
# Conflicts: # TewlTester/Program.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.