Skip to content

Conversation

@deeebug
Copy link

@deeebug deeebug commented Jan 13, 2021

Feel free to change or request anything for the merge.

@Grouflon
Copy link
Owner

Hey, I finally got the time to test your branch, thanks again for contributing :).
I don't know if I got it correctly, but I think that the behavior is not really what I had in mind with this feature.
For me it should block the first blockstring, and as soon as the blockstring ends, it should stop blocking until the next hit or some time pass without anything happening.
If I understand the code correctly, what you wrote will make the dummy block until 90 frames pass with the dummy not having any hit or block.
Can you tell me a little bit more about what you think ?

@deeebug
Copy link
Author

deeebug commented Jan 21, 2021

Well, I intended this mode to be where you could test true combo strings. First hit would be let in and anything following that shouldn't work until 90 frames. Of course, if it's a true combo string the consecutive hits would work, otherwise anything will be blocked. Hence, "after first hit".

By the way, didn't notice that you had an issue up for a block mode with a similar name until a PR was sent. But, isn't this what you wrote in that issue? Or maybe it's not working that way, somehow?

@alepaez
Copy link

alepaez commented Sep 13, 2021

Hello! :D

I have tested the feature and works fine, but I think this code could be more clear and DRY.

Is this PR going to be merged? I also have a woking version that can be used :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants