Closed
Conversation
When using /sell-all with items that have player limits (e.g., 512 coal per 24h), overflow items were being combined into single slots with illegal stack sizes, causing player kicks. Changes: - Added partial selling support for both server and player limits - When a stack exceeds the limit, now sells only what fits within the limit - Overflow items are properly returned to inventory split into legal stack sizes - Updated price calculation to reflect actual amount sold instead of full stack - Ensured item removal uses the adjusted amount Example: If player can sell 32 more coal but has a stack of 64, the plugin now sells 32 and returns 32 to inventory, rather than skipping the entire stack.
alwyn974
deleted the
claude/fix-sell-all-player-limit-011CUq3oWJGjw6PifGVcvB7T
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using /sell-all with items that have player limits (e.g., 512 coal per 24h), overflow items were being combined into single slots with illegal stack sizes, causing player kicks.
Changes:
Example: If player can sell 32 more coal but has a stack of 64, the plugin now sells 32 and returns 32 to inventory, rather than skipping the entire stack.