Expose closeable event listener in twisted #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RazorBest
changed the title
|
I think we should squash all commits into a single commit for better review and merging. Rebase your branch onto main and squash all the commits. Thanks for your work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the function
create_listener, for pycdp.twisted, so the user can cancel it.Remove
_CLOSE_SENTINEL, because you can directly use Deferred.close to achieve the same effect.Added tests for
CDPEventListener.There's still an isssue with the internal state. I don't know what should happen whenaiter(listener)is called multiple times.