Replace store_thm calls with Theorem in examples #1719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It claimed that it cannot be parsed in modern syntax, but apparently it can.
Contributor
Author
|
|
Member
|
The only good thing here (for me, and perhaps for others) is that there's no much room left for such grammar changes, i.e. the peace is finally coming. |
Member
|
Our long national nightmare is finally over? :) |
Contributor
Author
|
I think we are still a few (tens of) thousands of lines away from that 🫠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It feels like I am committing a crime just opening a PR of this size, but here we are. Maybe it makes sense to ask ourselves which files we care about and restrict changes to those?
To be clear, I don't have a problem making these changes; it's just that I don't think anyone can claim to have reviewed this beyond glancing over the diffs.