Skip to content

remove the updating of h2osoi_liq in Update enkf_clm_mod_5.F90 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Buliao1 wants to merge 4 commits into
base: tsmp-pdaf-patched-snow
Choose a base branch
from
Open

remove the updating of h2osoi_liq in Update enkf_clm_mod_5.F90 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7218d3d
Snow-DA: introduce `clmupdate_snow.eq.4` and refactor
jjokella Mar 21, 2025
75504d5
Snow-DA: update CLM3.5
jjokella Mar 21, 2025
55311a8
Snow-DA: Typo-fix
jjokella Mar 25, 2025
74dd63b
remove the updating the h2osoi_liq in Update enkf_clm_mod_5.F90
Buliao1 Mar 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion interface/model/clm3_5/enkf_clm_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,10 +157,16 @@ subroutine define_clm_statevec(mype)
error stop "Not implemented: clmupdate_snow.eq.1 or clmupdate_snow.eq.1"
endif
! Case 3: Assimilation of snow depth: Snow depth and snow water
! equivalent in the state vector
! equivalent in the state vector. Update of h2osoi_ice
if(clmupdate_snow.eq.3) then
error stop "Not implemented: clmupdate_snow.eq.3"
endif
! Case 4: Assimilation of snow depth: Snow depth and snow water
! equivalent in the state vector. Update of h2osoi_ice, h2osoi_liq
! and dz
if(clmupdate_snow.eq.4) then
error stop "Not implemented: clmupdate_snow.eq.4"
endif

!hcp LST DA
if(clmupdate_T.eq.1) then
Expand Down
142 changes: 103 additions & 39 deletions interface/model/clm5_0/enkf_clm_mod_5.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,11 +282,18 @@ subroutine define_clm_statevec(mype)
clm_statevecsize = (clm_endg-clm_begg+1) ! So like this if snow is set it takes priority
endif
! Case 3: Assimilation of snow depth: Snow depth and snow water
! equivalent in the state vector
! equivalent in the state vector. Update of h2osoi_ice
if(clmupdate_snow.eq.3) then
clm_varsize = (clm_endg-clm_begg+1)
clm_statevecsize = 2*(clm_endg-clm_begg+1)
endif
! Case 4: Assimilation of snow depth: Snow depth and snow water
! equivalent in the state vector. Update of h2osoi_ice, h2osoi_liq
! and dz
if(clmupdate_snow.eq.4) then
clm_varsize = (clm_endg-clm_begg+1)
clm_statevecsize = 2*(clm_endg-clm_begg+1)
endif

!hcp LST DA
if(clmupdate_T.eq.1) then
Expand Down Expand Up @@ -430,6 +437,9 @@ subroutine set_clm_statevec(tstartcycle, mype)
else if(clmupdate_snow.eq.3) then
clm_statevec(cc+offset) = snow_depth(jj)
clm_statevec(cc+clm_varsize+offset) = h2osno(jj)
else if(clmupdate_snow.eq.4) then
clm_statevec(cc+offset) = snow_depth(jj)
clm_statevec(cc+clm_varsize+offset) = h2osno(jj)
else
error stop "Wrong input for clmupdate_snow"
end if
Expand Down Expand Up @@ -484,9 +494,12 @@ subroutine update_clm(tstartcycle, mype) bind(C,name="update_clm")
real(r8), pointer :: h2osoi_liq(:,:) ! liquid water (kg/m2)
real(r8), pointer :: h2osoi_ice(:,:)

real(r8) :: rliq,rice,incr_sno
real(r8) :: rsnow(clm_begc:clm_endc)
real(r8) :: nsnow(clm_begc:clm_endc)
real(r8) :: rliq,rice
real(r8) :: incr_sno
real(r8) :: incr_sd
real(r8) :: incr_swe
real(r8) :: h2osno_in(clm_begc:clm_endc)
real(r8) :: snow_depth_in(clm_begc:clm_endc)
real(r8) :: watmin_check ! minimum soil moisture for checking clm_statevec (mm)
real(r8) :: watmin_set ! minimum soil moisture for setting swc (mm)
real(r8) :: swc_update ! updated SWC in loop
Expand Down Expand Up @@ -721,42 +734,47 @@ subroutine update_clm(tstartcycle, mype) bind(C,name="update_clm")
! CLM5-grid-index
cc = (col%gridcell(j) - clm_begg + 1)

snow_depth_in(j) = snow_depth(j)
h2osno_in(j) = h2osno(j)

if (clmupdate_snow.eq.1) then
rsnow(j) = snow_depth(j)
snow_depth(j) = clm_statevec(cc+offset)
else if (clmupdate_snow.eq.2) then
rsnow(j) = h2osno(j)
h2osno(j) = clm_statevec(cc+offset)
else if (clmupdate_snow.eq.3) then
rsnow(j) = h2osno(j)
h2osno(j) = clm_statevec(cc+clm_varsize+offset)
else if (clmupdate_snow.eq.4) then
snow_depth(j) = clm_statevec(cc+offset)
h2osno(j) = clm_statevec(cc+clm_varsize+offset)
end if

if (clmupdate_snow.eq.1 .or. clmupdate_snow.eq.2) then
nsnow(j) = clm_statevec(cc+offset)
else if (clmupdate_snow.eq.3) then
nsnow(j) = clm_statevec(cc+clm_varsize+offset)
if (snow_depth(j).lt.0.0) then
! Catch negative values from DA
print *, "WARNING: Snow-depth is negative at state vector cc. cc, j, offset, snow_depth(j): ", cc, j, offset, snow_depth(j)
print *, "WARNING: Snow-depth is reset to pre-DA value."
snow_depth(j) = snow_depth_in(j)
end if

if (nsnow(j).gt.0.0) then
! Update state variable to CLM
! Not needed for repartioning-case 3?
if(clmupdate_snow.eq.1) then
snow_depth(j) = nsnow(j)
end if
if(clmupdate_snow.eq.2 .or. clmupdate_snow.eq.3) then
h2osno(j) = nsnow(j)
end if
else
! Catch negative or 0 values from DA
print *, "WARNING: Snow-statevec is negative/zero at cc. cc, j, offset, clm_statevec(cc+offset): ", cc, j, offset, clm_statevec(cc+offset)
if (h2osno(j).lt.0.0) then
! Catch negative values from DA
print *, "WARNING: SWE is negative at state vector cc. cc, j, offset, h2osno(j): ", cc, j, offset, h2osno(j)
print *, "WARNING: SWE is reset to pre-DA value or zero."
h2osno(j) = h2osno_in(j)
end if

end do

! Repartitioning
if ( clmupdate_snow_repartitioning.eq.1 .or. clmupdate_snow_repartitioning.eq.2) then

if (clmupdate_snow.eq.1 .or. clmupdate_snow.eq.2) then
if ( SUM(ABS(rsnow(:) - nsnow(:))).gt.0.000001) then
call clm_repartition_snow(rsnow(:))
if (clmupdate_snow.eq.1) then
if ( SUM(ABS(snow_depth_in(:) - snow_depth(:))).gt.0.000001) then
call clm_repartition_snow(snow_depth_in(:))
end if
end if

if (clmupdate_snow.eq.2) then
if ( SUM(ABS(h2osno_in(:) - h2osno(:))).gt.0.000001) then
call clm_repartition_snow(h2osno_in(:))
end if
end if

Expand All @@ -768,19 +786,65 @@ subroutine update_clm(tstartcycle, mype) bind(C,name="update_clm")

if ( clmupdate_snow_repartitioning.eq.3) then

do j=clm_begc,clm_endc
if (nsnow(j).gt.0.0) then
if ( ABS(rsnow(j) - nsnow(j)).gt.0.000001) then
if ( ABS(rsnow(j)).gt.0.0) then
! Update h2osoi_ice with increment
incr_sno = nsnow(j) / rsnow(j) ! INC = New snow var / OLD snow var
do i=snlsno(j)+1,0
h2osoi_ice(j,i) = h2osoi_ice(j,i) * incr_sno
end do
if (clmupdate_snow.eq.1) then
do j=clm_begc,clm_endc
if (snow_depth(j).gt.0.0) then
if ( ABS(snow_depth_in(j) - snow_depth(j)).gt.0.000001) then
if ( ABS(snow_depth_in(j)).gt.0.0) then
! Update h2osoi_ice with increment
incr_sno = snow_depth(j) / snow_depth_in(j)
do i=snlsno(j)+1,0
h2osoi_ice(j,i) = h2osoi_ice(j,i) * incr_sno
end do
end if
end if
end if
end if
end do
end do
end if

if (clmupdate_snow.eq.2 .or. clmupdate_snow.eq.3) then
do j=clm_begc,clm_endc
if (h2osno(j).gt.0.0) then
if ( ABS(h2osno_in(j) - h2osno(j)).gt.0.000001) then
if ( ABS(h2osno_in(j)).gt.0.0) then
! Update h2osoi_ice with increment
incr_sno = h2osno(j) / h2osno_in(j)
do i=snlsno(j)+1,0
h2osoi_ice(j,i) = h2osoi_ice(j,i) * incr_sno
end do
end if
end if
end if
end do
end if

if (clmupdate_snow.eq.4) then
do j=clm_begc,clm_endc
if (h2osno(j).gt.0.0) then
if ( ABS(h2osno_in(j) - h2osno(j)).gt.0.000001) then
if ( ABS(h2osno_in(j)).gt.0.0) then
! Update h2osoi_ice/h2osoi_liq with increment
incr_swe = h2osno(j) / h2osno_in(j)
do i=snlsno(j)+1,0
h2osoi_ice(j,i) = h2osoi_ice(j,i) * incr_swe
h2osoi_liq(j,i) = h2osoi_liq(j,i) * incr_swe
end do
end if
end if
end if
if (snow_depth(j).gt.0.0) then
if ( ABS(snow_depth_in(j) - snow_depth(j)).gt.0.000001) then
if ( ABS(snow_depth_in(j)).gt.0.0) then
! Update snow_depth with increment
incr_sd = snow_depth(j) / snow_depth_in(j)
do i=snlsno(j)+1,0
dz(j,i) = dz(j,i) * incr_sd
end do
end if
end if
end if
end do
end if

end if

Expand Down Expand Up @@ -879,7 +943,7 @@ subroutine clm_repartition_snow(h2osno_in)
h2osno_po(jj) = snow_depth(jj) * denice
end if
h2osno_pr(jj) = h2osno(jj)
else if (clmupdate_snow .eq. 2 .or. clmupdate_snow .eq. 3) then
else if (clmupdate_snow .eq. 2) then
! for clmupdate_snow == 2 we have post H2OSNO as the main H2OSNO already
h2osno_po(jj) = h2osno(jj)
h2osno_pr(jj) = h2osno_in(jj)
Expand Down
Loading