Open
Conversation
Collaborator
|
Probably we'll need to change literals |
Collaborator
|
Also I noticed an old typo on line 87. |
Collaborator
Author
|
Can I simply replace it with the dict in hydrus? https://github.com/HTTP-APIs/hydrus/blob/develop/hydrus/samples/hydra_doc_sample.py I think changing the file format might be a problem for the demo, so if Akshay says so I'll just close this issue and add one more file so we have it on both formats. |
Collaborator
Yeah you can.
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related: #1 and HTTP-APIs/hydra-python-core#29
Simply changing the format so we import:
from hydra-flock-vocab.hydra_flock import flock_doc