Skip to content

Conversation

@404yonara
Copy link
Contributor

svg를 컴포넌트화 하였습니다.

                {challengeDetail ? (
                    <ChevronUpIcon className="size-6" />
                  ) : (
                    <ChevronDownIcon className="size-6" />
                  )}

/app/components/icons 폴더에 svg아이콘을 하나씩 컴포넌트로 만들었습니다.
prop으로 className을 받습니다. tailwind css와 호환됩니다.

@404yonara 404yonara self-assigned this Jan 22, 2025
@404yonara
Copy link
Contributor Author

회의할 당시에는 꼭 필요한가 싶었는데, 바꾸고 보니 훨씬 깔끔합니다. 좋은의견감사합니다.

@404yonara 404yonara merged commit 078a264 into main Jan 22, 2025
1 check passed
@404yonara 404yonara deleted the feat/svgComponents#177 branch January 22, 2025 08:31
Copy link
Contributor

@Han-Joon-Hyeok Han-Joon-Hyeok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

바꿀 부분이 많아서 번거로우셨을텐데 고생 많으셨습니다! 나중에 재활용해서 쓰일 때 진가를 발휘할 것 같아요.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants