Merge upstream #18
Merge upstream #18
Conversation
| ```bash | ||
| sudo apt update | ||
| sudo apt install build-essential python3 | ||
| sudo apt install build-essential python3 wget |
There was a problem hiding this comment.
We don't use wget do we? i thought that was just to download the versions of gcc for matching
There was a problem hiding this comment.
We can also remove it, I just want the commit for the sake of not being behind or splitting off
There was a problem hiding this comment.
Aren't we by definition splitting off? It's not like there's non matching functions to worry about
There was a problem hiding this comment.
I guess, but I'd rather stay up to date with upstream in general if it's not too much of a pain to do so. Otherwise it can make us look 'outdated'.
There was a problem hiding this comment.
I guess for now we can just grab the commits and then immediately undo them with a revert commit or otherwise (which also probably means this PR would need its own branch)
|
ok apparently this fails CI because it's using upstream as-is (which does not have the check-format tool); can you like rebase the 2 commits onto hackerlibultra main? (besides being theoretically good practice ™️ , I don't think i can even press the merge button unless CI passes) |
6 participants
May as well I guess