-
Notifications
You must be signed in to change notification settings - Fork 0
Thad/jira 58 create dashboard page #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… overall section.
…esign of Tab Section.
…en adding/editing cards
… tab section as well
into the secrets.js file. updated compose file for this.
…l, tried updating designs for UpdateItemPanel.
…e instead of using the dummy data
|
There is one or more linting errors (Backend) Lint Issuesnpm warn exec The following package was not found and will be installed: @biomejs/biome@2.1.1 Backend/app.js:7:20 lint/style/useNodejsImportProtocol FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━i A Node.js builtin module should be imported with the node: protocol.
i Using the node: protocol is more explicit and signals that the imported module belongs to Node.js. i Unsafe fix: Add the node: protocol. Backend/tests/integration/stances.integration.test.js:135:28 lint/complexity/useLiteralKeys FIXABLE ━━━━━━━━━━ i The computed expression can be simplified without the use of a string literal.
i Unsafe fix: Use a literal key instead. Backend/tests/integration/stances.integration.test.js:136:28 lint/complexity/useLiteralKeys FIXABLE ━━━━━━━━━━ i The computed expression can be simplified without the use of a string literal.
i Unsafe fix: Use a literal key instead. Backend/app.js:5:7 lint/correctness/noUnusedVariables FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ! This variable analyticsRoutes is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. i Unsafe fix: If this is intentional, prepend analyticsRoutes with an underscore. Backend/app.js:7:7 lint/correctness/noUnusedVariables FIXABLE ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ! This variable fs is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. i Unsafe fix: If this is intentional, prepend fs with an underscore. Backend/routes/dashboard.route.js:5:9 lint/correctness/noUnusedVariables ━━━━━━━━━━━━━━━━━━━━━━━━━━━ ! This variable management is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. Backend/routes/users.route.js:14:12 lint/correctness/noUnusedFunctionParameters FIXABLE ━━━━━━━━━━ ! This parameter is unused.
i Unused parameters might be the result of an incomplete refactoring. i Unsafe fix: If this is intentional, prepend req with an underscore. Backend/routes/users.route.js:36:12 lint/correctness/noUnusedFunctionParameters FIXABLE ━━━━━━━━━━ ! This parameter is unused.
i Unused parameters might be the result of an incomplete refactoring. i Unsafe fix: If this is intentional, prepend req with an underscore. Backend/routes/users.route.js:63:15 lint/correctness/noUnusedVariables FIXABLE ━━━━━━━━━━━━━━━━━━━ ! This variable validators is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. i Unsafe fix: If this is intentional, prepend validators with an underscore. Backend/tests/unit/auth.unit.test.js:69:30 lint/correctness/noUnusedFunctionParameters FIXABLE ━━━━━━━━━━ ! This parameter is unused.
i Unused parameters might be the result of an incomplete refactoring. i Unsafe fix: If this is intentional, prepend res with an underscore. Backend/tests/unit/auth.unit.test.js:69:35 lint/correctness/noUnusedFunctionParameters FIXABLE ━━━━━━━━━━ ! This parameter is unused.
i Unused parameters might be the result of an incomplete refactoring. i Unsafe fix: If this is intentional, prepend next with an underscore. Backend/tests/unit/dashboard.unit.test.js:12:7 lint/correctness/noUnusedVariables FIXABLE ━━━━━━━━━━ ! This variable middleware is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. i Unsafe fix: If this is intentional, prepend middleware with an underscore. Backend/tests/unit/users.unit.test.js:290:15 lint/correctness/noUnusedVariables FIXABLE ━━━━━━━━━━ ! This variable expected is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. i Unsafe fix: If this is intentional, prepend expected with an underscore. Backend/utils/auth0.middleware.js:6:5 lint/correctness/noUnusedVariables ━━━━━━━━━━━━━━━━━━━━━━━━━━━ ! This variable InsufficientScopeError is unused.
i Unused variables are often the result of an incomplete refactoring, typos, or other sources of bugs. Backend/tests/unit/DAL.unit.test.js:755:58 lint/suspicious/noDuplicateObjectKeys FIXABLE ━━━━━━━━━━ × This property is later overwritten by an object member with the same name.
i Overwritten with this property.
i If an object property with the same name is defined multiple times (except when combining a getter with a setter), only the last definition makes it into the object and previous definitions are ignored. i Unsafe fix: Remove this property. Checked 42 files in 96ms. Fixed 1 file. × Some errors were emitted while running checks. |
🧪 Admin Dashboard Test Results33 tests 33 ✅ 1s ⏱️ Results for commit 441b9eb. ♻️ This comment has been updated with latest results. |
🧪 Backend Unit Test Results 1 files ± 0 18 suites +1 2m 39s ⏱️ + 1m 38s Results for commit 441b9eb. ± Comparison against base commit 674828f. This pull request removes 67 and adds 26 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
call. Frontend: Fixed an issue where Navbar reference still existed in App.js. Dashboard: Added dark mode designs
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #34 +/- ##
==========================================
- Coverage 97.23% 92.03% -5.20%
==========================================
Files 17 20 +3
Lines 688 829 +141
==========================================
+ Hits 669 763 +94
- Misses 19 66 +47 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…om/Harjun751/UnderStance into thad/JIRA-58-create-dashboard-page
Harjun751
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Top 10 PR of all time, lgtm, we fix codecov later :)
IN THIS EPISODE OF PR (WHAT THE DOG DOIN?)
NEW FEATURES 🥇
Fully customizable Admin Dashboard!
Overall Section (Whatever you need comes first!)
Tabs Section (JESSE, we need to ORGANIZE)
Analytics Section (Boys, are we cooking with these analytics?)
Design in dark mode 🌚