Generate non deprecated metadata#1377
Open
riccardo-aolis wants to merge 2 commits intoHashLips:mainfrom
Open
Conversation
Changes on the metadata structure in order to generate non deprecated data for solana collections
|
thank you! 🤲 |
DaWe35
reviewed
Dec 10, 2022
src/main.js
Outdated
| ) | ||
| : null; | ||
|
|
||
| delete metadata.edition; |
There was a problem hiding this comment.
Why do you delete it, when you can just delete the line what includes this data?
What's the point of add edition and then delete edition?
There was a problem hiding this comment.
The edition is used on saveMetaDataSingleFile as well, as a reference to get the right set of data.
You could edit saveMetaDataSingleFile and use the name of the image for instance, or change the structure of it but mine was just a quick fix.
One thing that I got wrong is that it's necessary an if statement to check if the network is solana.
See review below.
zquestz
added a commit
to cashninjas/shinobi-art-engine
that referenced
this pull request
Oct 1, 2023
binaryck
suggested changes
Oct 15, 2023
binaryck
left a comment
binaryck
left a comment
There was a problem hiding this comment.
It's necessary an if statement to check if the network is solana
binaryck
suggested changes
Oct 15, 2023
src/main.js
Outdated
| ) | ||
| : null; | ||
|
|
||
| delete metadata.edition; |
There was a problem hiding this comment.
Suggested change
| delete metadata.edition; | |
| if(network === NETWORK.sol) delete metadata.edition; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes on the metadata structure in order to generate non deprecated data for solana collections