Pull uncontroversial changes from haxe-numeric branch#12851
Merged
Simn merged 1 commit intodevelopmentfrom Mar 20, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR pulls a set of “uncontroversial” changes from the haxe-numeric branch, primarily aligning 32-bit I/O APIs with haxe.Int32 across the std library and improving stability of HL bytecode comparison tests, alongside a few repo/config maintenance updates.
Changes:
- Standardize 32-bit I/O-related APIs (
readInt32,writeInt32,getInt32,setInt32,addInt32, andFPHelperi32/i64 helpers) to usehaxe.Int32in std and target-specific std implementations. - Improve
tests/hlcodenormalization by also stabilizing integer constant pool references in HL dumps. - Minor repo maintenance: tweak unit VS Code settings, extend
.gitignore, and bootstraphxcppin the Copilot setup workflow + document it.
Reviewed changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/unit/src/unit/issues/Issue2718.hx | Adjust regression to use Map<UInt, String> consistently with UInt keys. |
| tests/unit/.vscode/settings.json | Disable Haxe formatOnSave for the unit tests workspace settings. |
| tests/hlcode/src/Macro.hx | Normalize int R,@N constant pool refs in HL dump comparisons. |
| std/python/io/IOutput.hx | Change writeInt32 parameter type from Int to Int32. |
| std/python/io/IInput.hx | Change readInt32 return type from Int to Int32. |
| std/python/_std/sys/io/FileOutput.hx | Update override signature to writeInt32(x:Int32). |
| std/python/_std/sys/io/FileInput.hx | Update override signature to readInt32():Int32. |
| std/python/_std/haxe/io/FPHelper.hx | Use Int32 for i32 conversions and i64 low/high parameters. |
| std/php/_std/haxe/io/FPHelper.hx | Use Int32 for i32 conversions and i64 low/high parameters. |
| std/php/_std/haxe/io/BytesBuffer.hx | Change addInt32 to accept Int32. |
| std/php/_std/haxe/io/Bytes.hx | Change getInt32/setInt32 to Int32. |
| std/lua/_std/haxe/io/FPHelper.hx | Use Int32 for i32 conversions and i64 low/high parameters. |
| std/js/_std/haxe/io/BytesBuffer.hx | Change addInt32 to accept Int32. |
| std/js/_std/haxe/io/Bytes.hx | Change getInt32/setInt32 to Int32. |
| std/java/lang/Integer.hx | Add missing extern overload for Integer.toUnsignedString(int). |
| std/hl/_std/haxe/io/FPHelper.hx | Use Int32 for i32 conversions and i64 low/high parameters. |
| std/hl/_std/haxe/io/BytesBuffer.hx | Change addInt32 to accept Int32. |
| std/hl/_std/haxe/io/Bytes.hx | Change getInt32/setInt32 to Int32. |
| std/haxe/io/Output.hx | Change writeInt32 signature to take Int32. |
| std/haxe/io/Input.hx | Change readInt32 signature to return Int32. |
| std/haxe/io/FPHelper.hx | Use Int32 for i32 conversions and i64 low/high parameters. |
| std/haxe/io/BytesOutput.hx | Update override signature to writeInt32(x:Int32) (Flash optimized path). |
| std/haxe/io/BytesInput.hx | Update override signature to readInt32():Int32 (Flash optimized path). |
| std/haxe/io/BytesBuffer.hx | Change addInt32 to accept Int32. |
| std/haxe/io/Bytes.hx | Change getInt32/setInt32 to Int32; use imported Int64 in getInt64/setInt64. |
| std/eval/_std/haxe/io/FPHelper.hx | Update extern signatures to use Int32 for i32 helpers and i64 parts. |
| std/eval/_std/haxe/io/BytesBuffer.hx | Update extern addInt32 signature to haxe.Int32. |
| std/eval/_std/haxe/io/Bytes.hx | Update extern getInt32/setInt32 signatures to haxe.Int32. |
| std/cpp/_std/haxe/io/FPHelper.hx | Use Int32 for i32 conversions and i64 low/high parameters. |
| std/cpp/_std/haxe/io/Bytes.hx | Change getInt32/setInt32 to Int32. |
| std/StringTools.hx | Remove Flash-specific hex() implementation, using the common bitwise version. |
| src/typing/functionArguments.ml | Adjust default-arg typing to use cast_or_unify and optionally run analyzer before constant check. |
| .gitignore | Ignore generated doc output under tests/docgen/cpp/ and extra/doc/. |
| .github/workflows/copilot-setup-steps.yml | Bootstrap hxcpp (haxe compile.hxml) during Copilot setup to avoid interactive hang. |
| .github/copilot-instructions.md | Document hxcpp bootstrapping requirement and troubleshooting guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not break anything.