Support suspend calls that don't actually suspend#166
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our recent changes to how
suspendandsuspendCancellablework means that they always suspend. This can be verified by using a counting dispatcher:This branch goes back to returning the continuation if it already is in
ReturnedorThrownmode after the closure passed tosuspendhas executed.This isn't entirely free though because it means we can no longer specify that the suspension functions don't return or throw, which means all call-sites have to check that again. So something like
hxcoro_Coro.yield(_hx_continuation);now is back to being this:I'm unsure what's better here. Even though I implemented this change, I wonder if it puts too much focus on the synchronous path, which may or may not be the special case. On the other hand avoiding the asynchronous bubbling in such cases would certainly be more efficient.
So yes, not sure!