Switch processing order in Fonduer tutorial#78
Open
YasushiMiyata wants to merge 2 commits intoHazyResearch:masterfrom
Open
Switch processing order in Fonduer tutorial#78YasushiMiyata wants to merge 2 commits intoHazyResearch:masterfrom
YasushiMiyata wants to merge 2 commits intoHazyResearch:masterfrom
Conversation
Changes to be committed:
modified: hardware/max_storage_temp_tutorial.ipynb
modified: hardware_image/transistor_image_tutorial.ipynb
modified: wiki/president_place_of_birth_tutorial.ipynb
(1) Switching the Multimodal Featurization process to ahead of training the Discriminative Model process.
(2) Fixing the tutorial sentence along with the outline in Fonduer paper.
(1) is because Fonduer’s Multimodal Featurization process affects not the Generative Model but the Discriminative Model.
Previous version is a little bit confusing to understand the difference between Discriminative Model and Generative Model.
In regards of (2), I guess that previous version intends collecting static process before the iterative process.
However, to understand Generative Model , Discriminative Model and Fonduer’s Multimodal Featurization,
it might be a better way to switch tutorial order and fix the tutorial sentence along with the switching.
Author
|
Hello, thank you for your "fonduer-tutorial" maintenance. I utilize Fonduer for my work. This is a proposal draft for better understanding of fonduer's Generative Model , Discriminative Model and Multimodal Featurization. |
Contributor
|
Thanks for your PR! Please let us know when it's ready. |
Author
|
Thank you for commenting me. I will ready within a day or a few days after re-checking. |
Changes to be committed:
modified: hardware/max_storage_temp_tutorial.ipynb
modified: wiki/president_place_of_birth_tutorial.ipynb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to be committed:
modified: hardware/max_storage_temp_tutorial.ipynb
modified: hardware_image/transistor_image_tutorial.ipynb
modified: wiki/president_place_of_birth_tutorial.ipynb
(1) Switching the Multimodal Featurization process to ahead of training the Discriminative Model process.
(2) Fixing the tutorial sentence along with the outline in Fonduer paper.
(1) is because Fonduer’s Multimodal Featurization process affects not the Generative Model but the Discriminative Model.
Previous version is a little bit confusing to understand the difference between Discriminative Model and Generative Model.
In regards of (2), I guess that previous version intends collecting static process before the iterative process.
However, to understand Generative Model , Discriminative Model and Fonduer’s Multimodal Featurization,
it might be a better way to switch tutorial order and fix the tutorial sentence along with the switching.