Open
Conversation
Contributor
Author
|
Edit: I've now added docs and fixed some bugs so it is ready for full code review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #106 by adding non-circular PSFs to the pipeline using photutils.
PSF Photometry is available as an option in
reduce. It is turned on and off from settings in thereduce.redfile. PSF Photometry is a three-step process:Because we can't make a contiguous image across window boundaries, PSF Photometry currently only works if all apertures are within a single window.
The PR also adds a new script
psfaperwhich will help create aperture files for crowded regions. Inpsfaperthe user is asked to zoom in on the region where they want to carry out PSF Photometry. The user then adds a small number of reference apertures and hits 'q'.The reference stars are then fit to constrain the shape of the PSF. With the PSF shape held fixed, the script then carries out multiple iterations of FIND-FIT-SUBTRACT to detect all sources in the region of interest, these are then added to the aperture file.
There is still work to do here, most significantly it needs documentation both inside the code and in the main docs to explain PSF photometry. However I think it is ready for a code review and some stress testing.