Fill in missing API info, put todo to verify MD5 hash of uploaded file #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I too had to reverse engineer the puush.me upload api to implement an open source client to use with linux. Together with this project, we can have an entirely open source puush-like software stack. :)
This pull request just fills in the missing parts of the API, and puts a todo with regard to verifying that the uploaded file's MD5 checksum matches what is expected. If you would like me to write and put in a pull request for the MD5 verification code myself I can do that as well.
I refrained from linking to my client in the readme as it seemed like shameless self promotion, but you are of course free to do that if you like.