Skip to content

🧹 fix(lint): configure ESLint to allow img tags in BusinessCard #123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
is0692vs wants to merge 2 commits into from
Closed

🧹 fix(lint): configure ESLint to allow img tags in BusinessCard #123

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
51083e6
🧹 fix(lint): configure ESLint to allow img tags in BusinessCard
google-labs-jules[bot] Apr 3, 2026
46bbe54
fix: include og image route in lint override
is0692vs Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,16 @@ import nextTs from "eslint-config-next/typescript";
const eslintConfig = defineConfig([
...nextVitals,
...nextTs,
{
files: [
"src/components/BusinessCard.tsx",
"src/lib/cardRenderer.tsx",
"src/app/api/og/*/route.tsx",
],
rules: {
"@next/next/no-img-element": "off",
},
},
// Override default ignores of eslint-config-next.
globalIgnores([
// Default ignores of eslint-config-next:
Expand Down
1 change: 0 additions & 1 deletion src/components/BusinessCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ const BusinessCard = forwardRef<HTMLDivElement, Props>(({ summary, layout, optio

const renderAvatarBlock = () => (
<div className="mb-10 flex items-center gap-8">
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src={profile.avatar_url}
alt={profile.login}
Expand Down
1 change: 0 additions & 1 deletion src/lib/cardRenderer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,6 @@ function createBlock(
alignItems: "center",
}}
>
{/* eslint-disable-next-line @next/next/no-img-element */}
<img
src={data.profile.avatarUrl}
width={58}
Expand Down
Loading