[DEV-551] Implement CommentsPanel#77
Merged
issacli-0821 merged 4 commits intoimplement-question-view-pagefrom Feb 25, 2026
Merged
[DEV-551] Implement CommentsPanel#77issacli-0821 merged 4 commits intoimplement-question-view-pagefrom
issacli-0821 merged 4 commits intoimplement-question-view-pagefrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
issacli-0821
requested changes
Feb 20, 2026
|
|
||
| const Thread: React.FC<{ comments: Comment[] }> = ({ comments }) => { | ||
| return ( | ||
| <div className='thread'> |
Contributor
There was a problem hiding this comment.
Let's convert all the divs to Panel evergreen element
| ); | ||
| }; | ||
|
|
||
| const CommentsPanel: React.FC<CommentsPanelProps> = ({ comments }) => { |
Contributor
There was a problem hiding this comment.
I think we can assume that the comments here all belong to the same answer. With that, idk if you need to do getThreadedComments?
I might have confused you, but the CommentsPanel component are just the comments associated with a single answer
…to comments-panel
issacli-0821
approved these changes
Feb 25, 2026
issacli-0821
merged commit 2189ee1
into
implement-question-view-page
2 of 5 checks passed
Spencer04Hire
added a commit
that referenced
this pull request
Feb 27, 2026
* Added Answer type to types.ts * Remove profilePicture from Answer type * CommentBox implementation with read more/read less option * Created AnswerPanel * Ran prettier and lint on AnswerPanel * removed accidental direct commit instead of pull request * Implement AnswerBox frontend component * Implement AnswerBox style * [DEV-552] Implement CommentBox (#80) * comment box * linting error fix * linting error fix * pull request comments * Modify comment type to be based on schema in commentService * Linting errors in types.ts --------- Co-authored-by: issacli-0821 <tl1719@princeton.edu> * [DEV-551] Implement CommentsPanel (#77) * wrote comments panel again * changed div to Pane and removed threads * Pass showThreadLine in CommentBox to conditionally render thread line --------- Co-authored-by: issacli-0821 <tl1719@princeton.edu> * Lint AnswerBox and AnswerPanel * Delete yarn.lock in root * Modify export paths to use path alias * Convert html elements to Evergreen components * Delete AnswerBox css * Update types and modified components to match * Remove unused imports in AnswerBox and AnswerPanel * Modify placement of elements in AnswerBox * Fix lint errors * Add truncation behavior for long answers * Wrap overflowing answers around the panel * Implementing QuestionPanel (#68) * Implementing QuestionPanel * Fixing linting errors while implementing question panel * Switching to using Evergreen elements * Fixing spacing between different import groups * Don't export types in comment service * Move max length constant into answer and comment files * Combine and fix formatTimePassed implementations * Prettier fixes --------- Co-authored-by: rayk <mrraykong@gmail.com> Co-authored-by: david.weizhong.liu@gmail.com <david.weizhong.liu@gmail.com> Co-authored-by: timothyli1331 <timothyli1331@gmail.com> Co-authored-by: davidweizhongliu <96628470+davidweizhongliu@users.noreply.github.com> Co-authored-by: Hellen Luo <luohellen05@gmail.com> Co-authored-by: mar-crespo <mcrespo2743@gmail.com> Co-authored-by: Spencer04Hire <124114480+Spencer04Hire@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes