DEV-446 Delete Stuff Post Handler & DEV-445 Create Stuff Post Handler#73
Open
ZhaoSongZh7 wants to merge 3 commits intopreviewfrom
Open
DEV-446 Delete Stuff Post Handler & DEV-445 Create Stuff Post Handler#73ZhaoSongZh7 wants to merge 3 commits intopreviewfrom
ZhaoSongZh7 wants to merge 3 commits intopreviewfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jfmath04
reviewed
Feb 25, 2026
| @@ -1,4 +1,4 @@ | |||
| .controls { | |||
| an.controls { | |||
jfmath04
reviewed
Feb 25, 2026
Contributor
There was a problem hiding this comment.
can we put this file back lol
jfmath04
reviewed
Feb 28, 2026
| {"error": "You already have a post."}, | ||
| status=status.HTTP_400_BAD_REQUEST | ||
| ) | ||
| StuffPost.objects.create(author=user, title=request.data.get("title"), description=request.data.get("description"), thumbnail_url=request.data.get("thumbnail_url"), category=request.data.get("category"), link_url=request.data.get("link_url"), tags=request.data.get("tags"), has_sent=False, created_at=timezone.now()) |
Contributor
There was a problem hiding this comment.
Can we turn this into a Model Serializer for StuffPost? It can go at the top of this file. It should be similar to the EventSerializer in the calendar repo. author should be a read_only field. The author info can be injected in after.
jfmath04
reviewed
Feb 28, 2026
| StuffPost.objects.filter(author=user).delete(); | ||
| return Response({"Status": "OK"}, status=status.HTTP_200_OK) | ||
| except StuffPost.DoesNotExist: | ||
| logger.error(f"Stuff post not found for user {user.email}") |
Contributor
There was a problem hiding this comment.
don't forget to initialize the logger at the top
jfmath04
reviewed
Feb 28, 2026
| ) | ||
| StuffPost.objects.create(author=user, title=request.data.get("title"), description=request.data.get("description"), thumbnail_url=request.data.get("thumbnail_url"), category=request.data.get("category"), link_url=request.data.get("link_url"), tags=request.data.get("tags"), has_sent=False, created_at=timezone.now()) | ||
| return Response({"status": "OK", "message": "Post made successfully"}, status=status.HTTP_200_OK) | ||
| except ValidationError as e: |
Contributor
There was a problem hiding this comment.
we can make this similar to the except clause in your delete handler.
jfmath04
reviewed
Feb 28, 2026
|
|
||
| return Response({"status": "OK", "message": "Stuff posts retrieved successfully"}, status=status.HTTP_200_OK) | ||
|
|
||
| def post(self, request) -> Response: |
Contributor
There was a problem hiding this comment.
can we add logging to this handler too?
jfmath04
requested changes
Feb 28, 2026
Contributor
jfmath04
left a comment
jfmath04
left a comment
There was a problem hiding this comment.
Left some comments for review!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References
Proposed Changes