Skip to content

bad response code on login error#145

Open
sdumetz wants to merge 1 commit intomainfrom
login_error_status
Open

bad response code on login error#145
sdumetz wants to merge 1 commit intomainfrom
login_error_status

Conversation

@sdumetz
Copy link
Member

@sdumetz sdumetz commented Mar 13, 2026

response status code was improperly forced to 200 on login failures when returning application/json or text/plain content.

Add regression tests

Additionally, update the handler to use async/await instead of a next handler.

},
"text/plain": ()=>{
res.status(code).send(e.message);
res.send(e.message);

Check warning

Code scanning / CodeQL

Exception text reinterpreted as HTML Medium

Exception text
is reinterpreted as HTML without escaping meta-characters.
@sdumetz sdumetz force-pushed the login_error_status branch from fa65017 to 9fbd49e Compare March 13, 2026 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant