Skip to content

Update message-inspector.ftl #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexeyLevin wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update message-inspector.ftl #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/resources/templates/message-inspector.ftl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@
<span class="label label-default">Compression:</span> ${msg.compressionCodec}
<div>
<a href="#" class="toggle-msg"><i class="fa fa-chevron-circle-right">&nbsp;</i></a>
<pre class="message-body">${msg.message!''}</pre>
<pre class="message-body"><xmp>${msg.message!''}</xmp></pre>
Copy link
Contributor

@dhayha dhayha Jul 16, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From my understanding, the <xmp> tag is considered obsolete and deprecated. This would probably be better handled at the Freemarker level as it would also address any XSS vulnerabilities related to displaying message data.

https://freemarker.apache.org/docs/dgui_misc_autoescaping.html

</div>
</div>
</#list>
Expand Down