formula_auditor: audit revision and compatibility_version
#20936
+429
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new audit method to check if the `revision` and `compatibility_version` are consistent with each other. This ensures that when a formula's `compatibility_version` is increased, the `revision` of dependent formulas was also increased. Inversely, when a formula's `revision` is increased in the same PR as one of its dependencies, the `compatibility_version` of dependent formulae must be increased by 1.
MikeMcQuaid
force-pushed
the
audit_revision_and_compatibility_version_relationships
branch
from
d7bae0f to
21b5d67
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for auditing compatibility_version changes in formulae and extends the existing revision audit to validate dependency relationships.
- Introduces a new
audit_compatibility_versionmethod that ensures compatibility versions don't decrease and only increment by 1, and that dependent formulae bump their revisions accordingly - Extends
audit_revisionto validate that when a formula's revision increases, changed dependencies must have their compatibility_version incremented by 1 - Refactors version info caching and adds a
changed_formulae_pathshelper method to identify changed formulae in a tap
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/formula_auditor.rb | Adds audit_compatibility_version method, extends audit_revision with dependency validation, adds changed_formulae_paths helper, and refactors version info caching to support multiple formulae |
| Library/Homebrew/test/formula_auditor_spec.rb | Adds comprehensive test coverage for both compatibility_version audits and revision-dependency relationship validation, including new test helper methods for formula creation and stubbing |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| relative_path = relative_path.sub_ext(".rb") if relative_path.extname.empty? | ||
| absolute_path = tap.formula_dir/relative_path | ||
| absolute_path.expand_path if absolute_path.exist? | ||
| rescue |
There was a problem hiding this comment.
Bare rescue clause catches all exceptions including system errors. This is a bad practice as it can mask critical errors. Consider specifying the specific exception types to rescue (e.g., rescue StandardError), or at a minimum document which exceptions are expected here.
Suggested change
| rescue | |
| rescue StandardError |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new audit method to check if the
revisionandcompatibility_versionare consistent with each other.This ensures that when a formula's
compatibility_versionis increased, therevisionof dependent formulas was also increased.Inversely, when a formula's
revisionis increased in the same PR as one of its dependencies, thecompatibility_versionof dependent formulae must be increased by 1.