Skip to content

Conversation

@cho-m
Copy link
Member

@cho-m cho-m commented Oct 28, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@cho-m cho-m added the CI-no-bottles Merge without publishing bottles label Oct 28, 2025
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Oct 28, 2025
@cho-m cho-m force-pushed the rqlite-arm64-linux branch from 28fc17a to 07033ad Compare October 28, 2025 13:24
@cho-m cho-m mentioned this pull request Oct 28, 2025
65 tasks
@cho-m cho-m force-pushed the rqlite-arm64-linux branch from 07033ad to 1507718 Compare October 28, 2025 13:43
@cho-m cho-m changed the title rqlite: workaround patchelf.rb bug when cgo is required rqlite: work around patchelf.rb bug when cgo is required Oct 28, 2025
@Homebrew Homebrew deleted a comment from github-actions bot Oct 28, 2025
@Homebrew Homebrew deleted a comment from github-actions bot Oct 28, 2025
@Homebrew Homebrew deleted a comment from github-actions bot Oct 28, 2025
@cho-m
Copy link
Member Author

cho-m commented Oct 28, 2025

@cho-m cho-m force-pushed the rqlite-arm64-linux branch from 1507718 to 64bfb47 Compare October 28, 2025 13:55
@cho-m cho-m marked this pull request as ready for review October 28, 2025 13:55
Copilot AI review requested due to automatic review settings October 28, 2025 13:56
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Oct 28, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a workaround for a patchelf.rb bug that affects the rqlite formula on Linux ARM64 systems when CGO is required for go-sqlite3. The workaround ensures proper build configuration by explicitly enabling CGO and configuring the linker to use PIE (Position Independent Executable) mode.

Key Changes:

  • Added platform-specific build configuration for Linux ARM64
  • Explicitly enabled CGO and external linking
  • Configured Go to build in PIE mode to prevent patchelf corruption

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@cho-m cho-m added the ready to merge PR can be merged once CI is green label Oct 28, 2025
@chenrui333 chenrui333 added this pull request to the merge queue Oct 28, 2025
Merged via the queue into main with commit f657e62 Oct 28, 2025
31 checks passed
@chenrui333 chenrui333 deleted the rqlite-arm64-linux branch October 28, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI-no-bottles Merge without publishing bottles go Go use is a significant feature of the PR or issue linux-arm-bottling ready to merge PR can be merged once CI is green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants