Skip to content

Fix Faker string type assertion to properly handle empty string and None #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
5xuanwen merged 2 commits into from
Nov 24, 2025
Merged

Fix Faker string type assertion to properly handle empty string and None #29

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be760d
Fix Faker string type assertion to properly handle empty string and N…
Nov 24, 2025
702a64e
Fix Faker string type assertion to properly handle empty string and N…
Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tests/fix_faker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,11 @@ def match_any(self, spec, got, want):
assert got in (None, b"", bytearray(b""), memoryview(b""))
else:
assert got == want
elif spec == str:
if want == "" or want is None:
assert got == "" or got is None
else:
assert got == want
else:
assert got == want

Expand Down
Loading