Open
Conversation
I've checked everything is working as expected, however I'm awaiting a reply from C/H to see what I can improve and I need to update the main file to reflect changes I've made to my subroutines
With default parameters code works, results may be nonsense. Checkpoint system complete, input-output system complete Working Makefile, however I compile all files with all libraries which may not be necessary Working Main pde compiles and runs
Found a bug where the concentration was not being saved as real64 produced a notebook to interpret output updated main so that volt_do now does turn on and off the voltage calculation
Rewrote input_output to accept var_ids as well as var_names to improve run speed Got the checkpoint system fully working, reading from, and writing to checkpoint Fixed issue with writing locations in output file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging Working Version