Add support for event http api #119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbisnett
requested changes
Oct 18, 2018
Collaborator
cbisnett
left a comment
cbisnett
left a comment
There was a problem hiding this comment.
This looks good. If you can make the one change and rebase this branch on master, I'll get it merged and released. Thanks.
| POST_EVENT_PATH = '/v1/event' | ||
|
|
||
| class << self | ||
| def complete(event_id, email, options = {}) |
Collaborator
There was a problem hiding this comment.
I think trigger would be a better word here (and in EventConnection) that more closely aligns with the documentation and intent of the API. The documentation refers to this endpoint as:
Trigger a custom HubSpot event using an HTTP GET call.
Open
Contributor
Author
|
Replaced by #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for enterprise events http api
https://developers.hubspot.com/docs/methods/enterprise_events/http_api
Also note that while running
bundle exec rspec spec/, new calls have been recorded to the vcr cassette about Contact.create_or_update