Conversation
supercedes #3
|
also supercedes #3 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files☔ View full report in Codecov by Sentry. |
|
The PR should be largely ready. Can you take a look and provide some feedback? The hanging tests is likely misconfigured branch protection rules. ping @ylep and @JoelChavas edit: I don't mind (In fact, I would recommend squash and merge) the PR to keep the commit history clean. |
ylep
left a comment
There was a problem hiding this comment.
I am completely ignorant of k8s and helm, so you have my full trust here, feel free to proceed with the merge!
@xgui3783 we now have container images including AimsApplyTransform that are based on Ubuntu 22.04, I should probably prepare a Docker version so that you can finally upgrade from obsolete dependencies (Ubuntu 18.04, Python 3.6)... ? Feel free to open an issue regarding that duty, and assign it to me.
|
Apologies, I only just now have time to report on this PR. I can report that the spatial backend is running well on the new k8s cluster the URL of the deployed service is at https://siibra-spatial-backend.apps.tc.humanbrainproject.eu/ , and we have a monitoring cron job running at https://github.com/FZJ-INM1-BDA/iav-dep-test/actions/workflows/siibra.dep.yml to monitor the health of the endpoint (e.g. https://github.com/FZJ-INM1-BDA/iav-dep-test/actions/runs/8295730452/job/22703360465 which monitors the new endpoint) I lack the sufficient right to merge in this repo. If you have a chance can you a/ update the merge checklist and ping @ylep |
|
I couldn't find a way of updating the merge checklist... hope the force-merge is fine. |
solves #4