adds integration with dynamic orders #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmielnicki
requested review from
mesutyang97,
micahcarroll and
nathan-miller23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows to work with dynamic_orders change. Should be merged along with PR in overcooked_ai repo HumanCompatibleAI/overcooked_ai#57 .
Fully backward compatible (works with https://github.com/HumanCompatibleAI/overcooked_ai/tree/master, works with https://github.com/bmielnicki/overcooked_ai/tree/dynamic_orders), unless you use layout that uses dynamic orders nothing really changes.
If you use dynamic orders timer for order is displayed below recipe icon. Colour indicates if order is bonus - yellow for ordinary order and green for bonus_order.
Except that I did minor cleaning in the code.
Code was tested by me using changes in Dockerfile to change overcooked_ai repos urls and by editing config to include dynamic orders layouts (this PR does not includes that changes).
Without adding dynamic orders layouts to config this PR does nothing from user perspective except it allows to work with dynamic orders PR (change in game.py allows that).