Conversation
Closed
Collaborator
Author
|
Pytest is 3.10+
Setup a smoke test for python 3.9 below |
Collaborator
|
I think this is good for now. running the help for each command should catch some things. We can expand as we go. I don't think it should be tests against a CDA/database build at this time at least. if it expands we might need to do something like that. |
Enovotny
previously approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up the framework to run recursive tests for the help pages of the CLI commands.
There are a few decisions we can make on how we handle these tests. Tossing some decisions to see if you agree @Enovotny?
cwms-cli blob downloadThis would ensure no changes of the outputs expected and break downstream processes.
For example, only run the
usgstests if changes to theusgsdir/src are in the PR. etc.Note i'm targeting a dev python version to run the tests of 3.10, but the library itself (cwms-cli) is targeting 3.9