Conversation
Adding physical_locations_CDA_test.py
Fixed tests
Update physical_locations_CDA_test.py
Enovotny
requested changes
Jul 23, 2025
| df_final = locations.get_locations( | ||
| office_id=TEST_OFFICE, location_ids=TEST_LOCATION_ID | ||
| ).df | ||
| assert TEST_LOCATION_ID not in df_final["name"].values |
Collaborator
There was a problem hiding this comment.
if there are no location the df from the get_locations call is empty. That is why your test is erroring out. You can either add 2 locations and then using the same assert. or check if it is empty. just checking that it is empty might not work if there is a lagging locations from another test hanging around. I would maybe place this test as the last test.
Collaborator
Author
There was a problem hiding this comment.
I moved the test and added the second location.
Made changes
Update physical_locations_CDA_test.py
|
Enovotny
approved these changes
Jul 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.