Skip to content

Minor changes in cmake and Encoder #621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
oganigl wants to merge 3 commits into
base: development
Choose a base branch
from
Open

Minor changes in cmake and Encoder #621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d13c667
modified regex from cmake and Moved the enum so doesn't depend on a t…
oganigl Apr 6, 2026
7da72c6
run pre-commit
oganigl Apr 6, 2026
97bd974
change encoder test to pass the tests
oganigl Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changesets/archive/v5.1.0/encoder-minor.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
release: minor
summary: Moved enum Direction to namespace ST-LIB, added more regex to cmake.
3 changes: 1 addition & 2 deletions Inc/ST-LIB_LOW/Sensors/EncoderSensor/NewEncoderSensor.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,8 @@
#include "C++Utilities/CppUtils.hpp"

namespace ST_LIB {

enum Direction : uint8_t { FORWARD = 0, BACKWARDS = 1 };
template <typename EncoderType, size_t SAMPLES> struct EncoderSensor {
enum Direction : uint8_t { FORWARD = 0, BACKWARDS = 1 };

private:
constexpr static size_t WINDOW_SIZE{(SAMPLES / 2) * 2};
Expand Down
6 changes: 3 additions & 3 deletions Tests/Time/encoder_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ TEST(EncoderSensorTest, ReadTreatsEncoderInitialCounterAsZeroPosition) {
double position = -1.0;
double speed = -1.0;
double acceleration = -1.0;
MockSensor::Direction direction = MockSensor::BACKWARDS;
ST_LIB::Direction direction = ST_LIB::Direction::BACKWARDS;

MockSensor sensor(encoder, 0.5, 0.1, &direction, &position, &speed, &acceleration);

Expand All @@ -112,7 +112,7 @@ TEST(EncoderSensorTest, ReadTreatsEncoderInitialCounterAsZeroPosition) {
EXPECT_DOUBLE_EQ(position, 0.0);
EXPECT_DOUBLE_EQ(speed, 0.0);
EXPECT_DOUBLE_EQ(acceleration, 0.0);
EXPECT_EQ(direction, MockSensor::FORWARD);
EXPECT_EQ(direction, ST_LIB::Direction::FORWARD);
}

TEST(EncoderSensorTest, ResetForwardsToEncoderAndClearsHistory) {
Expand All @@ -122,7 +122,7 @@ TEST(EncoderSensorTest, ResetForwardsToEncoderAndClearsHistory) {
double position = 0.0;
double speed = 0.0;
double acceleration = 0.0;
MockSensor::Direction direction = MockSensor::BACKWARDS;
ST_LIB::Direction direction = ST_LIB::Direction::BACKWARDS;

MockSensor sensor(encoder, 1.0, 1.0, &direction, &position, &speed, &acceleration);

Expand Down
Loading