Skip to content

fix: use makeAddr instead of vm.addr which creates a contract #74

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lirona merged 1 commit into from
Jul 15, 2025
Merged

fix: use makeAddr instead of vm.addr which creates a contract #74

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions test/Hyperfund.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ contract HyperfundTest is Test {
MockERC20 public fundingToken;
uint256 public hypercertTypeId;
uint256 public fractionHypercertId;
address public manager = vm.addr(1);
address public contributor = vm.addr(2);
address public contributor2 = vm.addr(3);
address public manager = makeAddr("manager");
address public contributor = makeAddr("contributor");
address public contributor2 = makeAddr("contributor2");
uint256 public totalUnits = 100000000;
uint256 public amount = 10000;
uint256 public amount2 = 20000;
Expand Down
6 changes: 3 additions & 3 deletions test/Hyperstaker.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,9 @@ contract HyperstakerTest is Test {
uint256 public hypercertTypeId;
uint256 public fractionHypercertId;
uint256 public stakerHypercertId;
address public manager = vm.addr(1);
address public staker = vm.addr(2);
address public staker2 = vm.addr(3);
address public manager = makeAddr("manager");
address public staker = makeAddr("staker");
address public staker2 = makeAddr("staker2");
uint256 public totalUnits = 100000000;
uint256 public stakeAmount = 10000;
uint256 public rewardAmount = 10 ether;
Expand Down
8 changes: 4 additions & 4 deletions test/Integration.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,10 @@ contract IntegrationTest is Test {
MockERC20 public fundingToken;
uint256 public hypercertTypeId;
uint256 public hypercertId;
address public manager = vm.addr(1);
address public contributor = vm.addr(2);
address public contributor2 = vm.addr(3);
address public contributor3 = vm.addr(4);
address public manager = makeAddr("manager");
address public contributor = makeAddr("contributor");
address public contributor2 = makeAddr("contributor2");
address public contributor3 = makeAddr("contributor3");
uint256 public totalUnits = 100000000;

bytes32 public MANAGER_ROLE = keccak256("MANAGER_ROLE");
Expand Down