GH-449: enhance development experience and Compile Time#450
Open
Marcel-TO wants to merge 2 commits intoHytaleModding:mainfrom
Open
GH-449: enhance development experience and Compile Time#450Marcel-TO wants to merge 2 commits intoHytaleModding:mainfrom
Marcel-TO wants to merge 2 commits intoHytaleModding:mainfrom
Conversation
Dokploy Preview Deployment
|
7 tasks
Marcel-TO
force-pushed
the
chore/improve-development-experience
branch
from
f3b9968 to
67a7ebe
Compare
…ge management scripts to improve compile time
Marcel-TO
force-pushed
the
chore/improve-development-experience
branch
from
67a7ebe to
1ca3988
Compare
ItsNeil17
requested review from
okunamayanad
and removed request for
ItsNeil17
Member
|
!bot sync |
|
✅ Synced with issue #449 📋 Labels: No labels on linked issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR intends to improve the development experience for developers and contributors by adjusting the development workflow.
When running the
bun run devcommand, the script does not execute theprebuild.tsfile but a new file for development calledpredev.ts. This file removes all languages from the documentation except english. With this change, the compile time is merely seconds instead of minutes.To prevent unwanted changes there is a new script called
bun run dev:restorethat restores all changes made by thepredev.tsfile.To prevent contributors from pushing the deleted files by accident (didnt run the restore script mentioned above) a pre-commit tool got implemented called Husky. Its goal is to restore the languages when the contributor creates a commit to prevent unwanted changes from any of the language files.
With those changes only local development gets a significant improvement in performance without changing anything on the codebase.
Type of Change
Screenshots
The following image is an example of the improved performance (7.9 seconds compiletime) for the whole documentation.
Checklist
bun run devbun formatbun audit(no critical vulnerabilities)Closes #449
Thank you for contributing!
gh-449