Batch email test for identity map #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aulme
force-pushed
the
aul-UID2-4666-batch-e2e-for-identity-map
branch
from
c96e802 to
7fff38b
Compare
| assertThat(response.at("/status").asText()).isEqualTo("success"); | ||
| } | ||
|
|
||
| @ParameterizedTest(name = "/v2/identity/map - {0} - {2}") |
There was a problem hiding this comment.
Just to be clear, did we only want to test v2 identity map here and not v3?
Contributor
Author
There was a problem hiding this comment.
We want both, but we don't have Identity Map V3 SDK yet. It's not merged, and the tests go via the SDK. I'll add the v3 test when we have the SDK merged.
| private static String randomHash() { | ||
| // This isn't really a hashed DII but looks like one ot UID2 | ||
| byte[] randomBytes = new byte[32]; | ||
| RANDOM.nextBytes(randomBytes); |
There was a problem hiding this comment.
Would this result in an invalid mapping or would it return some UID2 in the response?
Contributor
Author
There was a problem hiding this comment.
It would be some UID2. We don't check, and cannot possibly check, whether the hash maps back to any valid DII. From our perspective, it's just a certain amount of bytes.
sophia-chen-ttd
approved these changes
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.