UID2-4776 Add E2E test for remote config #96
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cYKatherine
force-pushed
the
kcc-UID2-4776-remote-config-e2e
branch
from
5593a9a to
22ed711
Compare
gmsdelmundo
reviewed
Apr 16, 2025
gmsdelmundo
reviewed
Apr 16, 2025
| () -> { | ||
| JsonNode runtimeConfig = response.get("runtime_config"); | ||
| assertNotNull(runtimeConfig, "runtime_config should not be null"); | ||
| assertEquals(3600, runtimeConfig.get("identity_token_expires_after_seconds").asInt(), "identity_token_expires_after_seconds"); |
Collaborator
There was a problem hiding this comment.
Can you set the four numbers here as static final vars at the top? Since we're setting these as defaults and not really changing them much, it might be clearer that way (and it's used in two different tests as well)
Contributor
Author
There was a problem hiding this comment.
Removed the specific checks for the value after discussing with @mcollins-ttd Will just check the structure of the response and make sure the value is not null
mcollins-ttd
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful run: https://github.com/IABTechLab/uid2-operator/actions/runs/14503733880