-
Notifications
You must be signed in to change notification settings - Fork 2
updates on the visualization #45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -39,10 +39,10 @@ | |
| def generate_bed_kriging( | ||
| icesee_path: str = "./", | ||
| data_path: str = "_modelrun_datasets", | ||
| Ne: int = 60, | ||
| stride_km: float = 10.0, | ||
| Ne: int = 100, | ||
| stride_km: float = 4, | ||
| snap_idx: int = 0, | ||
| sigma_noise: float = 15.0, | ||
| sigma_noise: float = 5.0, | ||
| sill_bed: float = 5000.0, | ||
| range_bed: float = 30000.0, | ||
| nugget_bed: float = 100.0, | ||
|
|
@@ -248,13 +248,13 @@ def parse_args() -> argparse.Namespace: | |
| parser.add_argument( | ||
| "--Ne", | ||
| type=int, | ||
| default=60, | ||
| default=100, | ||
| help="Number of ensemble realizations to generate (default: 60)", | ||
| ) | ||
| parser.add_argument( | ||
| "--stride-km", | ||
| type=float, | ||
| default=7.0, | ||
| default=4, | ||
| help="Radar track spacing in km (default: 7.0)", | ||
| ) | ||
| parser.add_argument( | ||
|
|
@@ -266,7 +266,7 @@ def parse_args() -> argparse.Namespace: | |
| parser.add_argument( | ||
| "--sigma-noise", | ||
| type=float, | ||
| default=10.0, | ||
| default=5.0, | ||
| help="Standard deviation of radar measurement noise in meters (default: 10.0)", | ||
| ) | ||
|
Comment on lines
266
to
271
|
||
| parser.add_argument( | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CLI help strings list old default values (60 / 7.0 / 10.0) that no longer match the actual defaults (100 / 4 / 5.0). Update the help text to reflect the new defaults so
--helpoutput is correct. (Minor: consider usingdefault=4.0for--stride-kmto match the float type and help formatting.)