-
Notifications
You must be signed in to change notification settings - Fork 14
Minor API Key Readme Update #286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
greglucas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that @tech3371 didn't want the export listed as a recommendation because then it sticks around for people in their environment and we don't want people accidentally uploading things in the future because they were still authenticated.
I'm fine with this though.
@greglucas I'll remove the export. For some reason it didn't seem to work for me without it, but maybe I mistyped something |
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
|
It won't work like this, I agree. So we should either revert this or keep what you had before. The export sets it for the entire session of the terminal, so it does work across lines. Whereas this now sets it on one line, then the next line forgets it. Previously this was all on the same line so that the API_KEY would affect the entire line but only that one line/command and not subsequent ones. Does that make sense? |
Change Summary
Overview
In the documentation for setting the API Key, I moved the environment variable setting step to a line before using the
imap-data-access, so it's more clear that it's not part of theimap-data-accesscommand. I also addedexportfor setting the environment variable