Bugs/productivity growth #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng input targets -- deven fix
… simulation made to have ~0 inflation
Fix for production being constrained at initial levels even with TFP growth. Root cause: compute_limiting_intermediate_inputs_stock() and compute_limiting_capital_inputs_stock() calculated production limits WITHOUT applying the TFP multiplier. These limits constrain target_production, which capped actual production at initial levels regardless of TFP growth. Before fix: TFP grew 1309% but production only grew 82% (12.9% efficiency) After fix: TFP grew 843% and production grew 476% (61% efficiency) Also fix empty array handling in SimpleTFPGrowth to prevent test failures.
The limiting_intermediate_inputs and limiting_capital_inputs are now TFP-scaled in set_targets() (from PR #57). This removes the duplicate scaling in compute_production() to avoid applying TFP twice to the limiting stock constraint. Labour scaling is kept since it's not pre-scaled elsewhere.
Apply TFP multiplier to limiting inputs in set_targets()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to address a bug found by Deven Azevedo from SESIT @devenaz , who noticed that firms were not properly taking into account their productivity investment needs for purchasing when buying capital inputs. This is now fixed by adding that quantity to the target capital inputs for purchasing.
In addition to this I have added a test that makes sure that when running the simulation with the price setting parameters set to 0 (meaning inflation is pushed towards 0 by preventing firms from changing prices) then we do observe positive GDP growth when setting up exogenous TFP growth.