feat(params): adding error case in UnmarshalInto func

[Caroline-theotter]

Current situation

curl https://polygon-mainnet.infura.io/v3/e35433ff37cb4c80aac3bc1afc8c0d08 --data '{
"id": 1,
"jsonrpc": "2.0",
"method": "eth_getLogs",
"params": [{
"fromBlock":"26843920",
"toBlock": "26843921",
"address": "0xc2132d05d31c914a87c6611c10748aeb04b58e8f",
"topics":["0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef"]
}]
}'

{
"jsonrpc": "2.0",
"id": 0,
"error": {
"code": -32602,
"message": "quantity values must start with 0x"
}
}

Expected situation

curl https://polygon-mainnet.infura.io/v3/e35433ff37cb4c80aac3bc1afc8c0d08 --data '{
"id": 1,
"jsonrpc": "2.0",
"method": "eth_getLogs",
"params": [{
"fromBlock":"26843920",
"toBlock": "26843921",
"address": "0xc2132d05d31c914a87c6611c10748aeb04b58e8f",
"topics":["0xddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef"]
}]
}'

{
"jsonrpc": "2.0",
"id": 0,
"error": {
"code": -32602,
"message": "invalid argument 0: quantity values must start with 0x"
}
}

Adding the indexation of the invalid argument

[basgys]

@Caroline-theotter I went through the PR, and I see a few red flags (reflect and the low-level JSON manipulation). It does not necessarily mean it is bad, but I need more context to properly review this PR.

Could you show me a simple example from your test case to fully understand the behavioural difference before and after your feature?

[ggarri]

Is this check required anymore? if you pass more receivers than params, isn't it enough to set them to nil? That seems to be the intended behavior copied across from go-ethereum library at line 169

[Caroline-theotter]

not sure to understand @ggarri

[basgys]

The only difference in the expected behaviour lies in the prefix invalid argument 0: .

I find this change quite heavy for an outcome that is unclear. This code is used in several projects and sometimes in hot paths, so I think an explicit motivation for this change and perhaps a benchmark to show how it performs would be great.

If you intend to mimic the behaviour of a specific implementation (e.g. Geth), then I would question if this is the right place for it. go-ethlibs is a generic implementation for json-rpc that can be used with any EVM-compatible chains.

[Caroline-theotter]

@basgys I understand you POV.
But can you give an example where that change can be problematic ?

And tell me if I'm wrong but that change can be a problem if a hardcoded error is in a condition, right ?

I checked in the infura repo where I can find, for example, the hardcoded error "quantity values must start with 0x" and found it only in return response not in condition.