Draft
Conversation
…st in the refactorings)
… handling - Add fallback to event.dataTransfer.files when webkitGetAsEntry() returns null (fixes Firefox drag-and-drop regression) - Set webkitRelativePath on files obtained via FileSystemFileEntry for consistency - Strip leading slash from entry.fullPath in both addFromDir and handleDroppedItems - Add folder selection button with webkitdirectory input for cross-browser folder uploads
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds a standalone file uploader (DVWebloader V2) that can be built as an independent bundle and embedded in external pages. It reuses the existing
FileUploaderPanelCorecomponent to avoid code duplication.Key features:
FileUploaderPanelCorefor the accordion uploader UIsiteUrl,datasetPid,key)window.dvWebloaderConfigfor S3 tagging, retries, and timeout settingsWhich issue(s) this PR closes:
Special notes for your reviewer:
npm run build-uploaderusingvite.config.uploader.ts@iqss/dataverse-client-javascriptto exportFilesConfig(see feat: add configurable file upload options and related tests dataverse-client-javascript#403)src/standalone-uploader/index.tsxStandaloneFileUploaderPanel.tsxis a thin wrapper (~70 lines) aroundFileUploaderPanelCoreSuggestions on how to test this:
npm run build-uploaderdist-uploaderfolderdvwebloaderV2.html?siteUrl=http://localhost:8080&datasetPid=doi:10.5072/FK2/XXXXX&key=YOUR_API_KEYDoes this PR introduce a user interface change? If mockups are available, please link/include them here:
Yes - adds a new standalone page for file uploads. The UI reuses the existing file uploader accordion from the SPA.
Is there a release notes or changelog update needed for this change?:
Yes - new feature: Standalone file uploader bundle for embedding in external pages (DVWebloader V2)
Additional documentation:
Configuration via
window.dvWebloaderConfig(set in HTML before bundle loads):URL parameters:
siteUrl- Dataverse instance URL (required)datasetPid- Dataset persistent ID (required)key- API key (required)dvLocale- Language code (optional, default: en)