Skip to content

Conversation

@MarkoSagadin
Copy link
Collaborator

Description

Add workflow for running pre-commit checks on the commits in PR and main branch.

Areas of interest for the reviewer

Is added readme clear?
Should workflow contain some additional checks?

Checklist

  • My code follows the style guidelines as defined by IRNAS.
  • I have performed a self-review of my code.
  • My changes generate no new warnings.
  • I added/updated source code documentation for all newly added or changed functions.
  • I updated all customer-facing technical documentation.

After-review steps

  • I will merge PR by myself.

Copy link
Collaborator Author

MarkoSagadin commented Mar 17, 2025

Copy link
Contributor

@TjazVracko TjazVracko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff.

I guess each project will now have to spend a bit more time configuring the pre-commit tools (writing exclusions, etc), so that pre-commit will pass all the commits...

@MarkoSagadin MarkoSagadin force-pushed the feature/pre-commit-workflow branch from 6b79f96 to f0e1bcc Compare March 17, 2025 13:10
@MarkoSagadin MarkoSagadin requested a review from TjazVracko March 17, 2025 13:18
@MarkoSagadin MarkoSagadin force-pushed the feature/pre-commit-workflow branch from d2ebca5 to f0e1bcc Compare March 17, 2025 13:53
@MarkoSagadin MarkoSagadin merged commit 40f6c8d into main Mar 21, 2025
1 check passed
@MarkoSagadin MarkoSagadin deleted the feature/pre-commit-workflow branch March 21, 2025 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants