Skip to content

[Bug] Remove Double Parenthesis#69

Merged
HazelYuAhiru merged 2 commits intomainfrom
fix/remove-double-parenthesis
Jul 29, 2025
Merged

[Bug] Remove Double Parenthesis#69
HazelYuAhiru merged 2 commits intomainfrom
fix/remove-double-parenthesis

Conversation

@HazelYuAhiru
Copy link
Collaborator

Overview

This PR fixes the issue of double parentheses in queries like IN ('s3', ('s1', 's2'))

Changes Made

  • Updated the replace logic
  • Re-parsed the query_ast in rewrite after applying changes from the matched rule
  • Added new test cases

Close #66

@HazelYuAhiru HazelYuAhiru changed the title [Bug] Remove Double Parenthesis [Bug] Remove Double Parenthesis (draft) Jul 18, 2025
@HazelYuAhiru HazelYuAhiru changed the title [Bug] Remove Double Parenthesis (draft) [Bug] Remove Double Parenthesis Jul 25, 2025
@HazelYuAhiru HazelYuAhiru marked this pull request as ready for review July 25, 2025 21:25
baiqiushi
baiqiushi previously approved these changes Jul 27, 2025
Copy link
Contributor

@baiqiushi baiqiushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good. Thanks!

colinthebomb1
colinthebomb1 previously approved these changes Jul 28, 2025
Copy link
Collaborator

@colinthebomb1 colinthebomb1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HazelYuAhiru HazelYuAhiru dismissed stale reviews from colinthebomb1 and baiqiushi via 9be80c8 July 29, 2025 20:30
@HazelYuAhiru HazelYuAhiru force-pushed the fix/remove-double-parenthesis branch from dc4db55 to 9be80c8 Compare July 29, 2025 20:30
@HazelYuAhiru HazelYuAhiru merged commit 29f66b2 into main Jul 29, 2025
2 checks passed
@HazelYuAhiru HazelYuAhiru deleted the fix/remove-double-parenthesis branch August 20, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] [BE] Remove Double Parenthesis

3 participants