Skip to content

minor ruff and pyright changes #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

minor ruff and pyright changes #71

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/genie_python/genie_toggle_settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,11 @@ class ToggleSettings:
@usercommand
@helparglist("")
@log_command_and_handle_exception
def exceptions_raised(toggle_on):
def exceptions_raised(toggle_on: bool) -> None:
"""
Set whether to allow exceptions to propagate (True) or let genie handle any exceptions (False).
By default (False), genie_python will handle any exceptions by printing the error message and carrying on.
By default (False), genie_python will handle any exceptions by printing the error message and
carrying on.

Args:
toggle_on (bool): Allow exceptions if True, let genie handle exceptions if False.
Expand All @@ -30,8 +31,6 @@ def exceptions_raised(toggle_on):

>>> exceptions_raised(True)
"""
if not isinstance(toggle_on, bool):
raise ValueError("Exceptions raised setting needs to be True or False.")
genie_python.genie_api_setup._exceptions_raised = toggle_on
# noinspection PyProtectedMember
print("Raise exceptions set to {}.".format(genie_python.genie_api_setup._exceptions_raised))
Expand All @@ -40,7 +39,7 @@ def exceptions_raised(toggle_on):
@usercommand
@helparglist("")
@log_command_and_handle_exception
def cset_verbose(verbose):
def cset_verbose(verbose: bool) -> None:
"""
Set the default verbosity of cset.

Expand All @@ -52,7 +51,5 @@ def cset_verbose(verbose):

>>> cset_verbose(True)
"""
if not isinstance(verbose, bool):
raise ValueError("Default verbosity needs to be True or False.")
ToggleSettings.cset_verbose = verbose
print("Default cset verbosity set to {}.".format(ToggleSettings.cset_verbose))