Add timing experiment files (WIP) #253
Draft
+2,545
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmjoy
commented
Nov 3, 2025
|
|
||
| interface: | ||
| state_hydration_domain: "p2triage" | ||
| input_output_filepath: ${test_data_dir}/July2025-AF-train_20250804_timing_subsample.json |
Contributor
Author
There was a problem hiding this comment.
Had some intention of setting the paths up here like they're done for the integration tests (using ${test_data_dir}) but am not convinced that's the best way. Currently this path should just be overridden on the command line.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@eveenhuis meant to share these files etc. with you when I tagged you on #251
I'm not convinced this is the right way to organize these experiment and input files etc. so leaving this as a draft PR for now.
I'll share the sweep sbatch script out of band.