This repository was archived by the owner on Jan 15, 2019. It is now read-only.
Fix crashes when some external APIs fail #1608
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add error handling code for chdir and pipe. When those APIs fail, print error message and return.
When chown fails, print error message and return.
Add error handling for external APIs
When chown fails, print error message and return.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I'm a PhD student. I analyzed the icinga source code and found some potential API bugs that may cause crashes.
These crashes are mainly caused by insufficient error handling of API functions like chown, chdir or pipe.
I think it's unsafe to assume the library function would be correct. It would be better if we could handle the error properly.
Best,
Zhouyang