Introduce common Kubernetes config CLI flags #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lippserd
requested changes
Sep 9, 2024
cmd/icinga-kubernetes/main.go
Outdated
| return nil | ||
| }) | ||
|
|
||
| flag.StringVar(&contextName, "context", "", "name of the kubeconfig context to use") |
Member
There was a problem hiding this comment.
Is context and cluster really necessary? Doesn't clientcmd.RecommendedConfigOverrideFlags("") already provide that options?
I have something like this in my stash:
loadingRules := clientcmd.NewDefaultClientConfigLoadingRules()
loadingRules.DefaultClientConfig = &clientcmd.DefaultClientConfig
overrides := clientcmd.ConfigOverrides{}
kflags := clientcmd.RecommendedConfigOverrideFlags("")
flag.StringVar(&loadingRules.ExplicitPath, "kubeconfig", "", "Path to a kube config. Only required if out-of-cluster")
clientcmd.BindOverrideFlags(&overrides, flag.CommandLine, kflags)
flag.Parse()
clientconfig := clientcmd.NewInteractiveDeferredLoadingClientConfig(loadingRules, &overrides, os.Stdin)
Collaborator
Author
There was a problem hiding this comment.
You are absolutely right! I have now also completely changed to ‘pflag’ (cause BindOverrideFlags needs a *pflag.FlagSet) and adapted the version-flag so that it also works with it
lippserd
force-pushed
the
feature/cli-flags
branch
from
6806371 to
45bd064
Compare
lippserd
changed the title
lippserd
force-pushed
the
feature/cli-flags
branch
from
45bd064 to
54cdcf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.