Skip to content

Self service: agent version: default to "latest" #2968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Al2Klimov wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Self service: agent version: default to "latest" #2968

Al2Klimov wants to merge 1 commit into from

Conversation

@Al2Klimov
Copy link
Member

@Al2Klimov Al2Klimov commented Mar 24, 2025

fixes #2965
fixes Icinga/icinga-powershell-framework#795

ref/IP/58492

CC @slalomsk8er

As discussed in Icinga/icinga-powershell-framework#795 (comment), pinning agent versions is a delayed shoot in the foot. Luckily IfW accepts "latest"!

Test

Spoiler: IfW accepts "latest" as version 👍

PS C:\Users\Administrator> & $ScriptFile `
>>     -ModuleDirectory  'C:\Program Files\WindowsPowerShell\Modules\' `
>>     -InstallCommand   '{"IfW-DirectorSelfServiceKey":{"Values":["61b1bc1cbbcd6bd49ebeab7cf60efedb54564b57"]},"IfW-DirectorUrl":{"Values":["http://10.27.0.54/icingaweb2/director/"]},"IfW-StableRepository":{"Values":["https://packages.icinga.com/IcingaForWindows/stable"]}}' `
>>     -IcingaRepository 'https://packages.icinga.com/IcingaForWindows/stable/ifw.repo.json'
[Notice]: Starting Icinga for Windows installation
[Notice]: Repository "Icinga Stable" is already registered. Forcing override of data.
[Error]: Failed to convert retreived content from repository "Icinga Stable" with location "https://packages.icinga.com/IcingaForWindows/stable" to JSON
[Notice]: Unable to fetch Icinga for Windows repository information for repository "Icinga Stable" from provided location. Trying different lookup by adding "ifw.repo.json" to the end of the remote path.
[Notice]: Downloading "agent" from "https://packages.icinga.com/IcingaForWindows/stable/agent/Icinga2-v2.14.5-x86_64.msi"
[Notice]: Installing component "agent" with version "2.14.5" into "C:\Program Files\ICINGA2"
[Notice]: Successfully backed up Icinga 2 Agent default config
[Passed]: The specified user "NT Authority\NetworkService" is allowed to run as service
[Passed]: Directory "C:\ProgramData\icinga2\etc" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\ProgramData\icinga2\var" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\cache" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\config" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\certificate" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Notice]: Service User "NT Authority\NetworkService" for service "icinga2" successfully updated
[Notice]: Installation of component "agent" with version "2.14.5" was successful.
[Notice]: Your hostname was successfully changed to "akw16"
[Notice]: The Icinga Service User already has permission to run as service
[Passed]: Directory "C:\ProgramData\icinga2\etc" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\ProgramData\icinga2\var" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\cache" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\config" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\certificate" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Notice]: Service User "NT Authority\NetworkService" for service "icinga2" successfully updated
[Passed]: Directory "C:\ProgramData\icinga2\etc" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\ProgramData\icinga2\var" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\cache" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\config" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\certificate" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Notice]: Feature "checker" was successfully disabled
[Notice]: Feature "notification" was successfully disabled
[Notice]: Feature "api" was successfully enabled
[Notice]: Api configuration has been written successfully
[Notice]: Windows Eventlog configuration has been written successfully to use severity level: warning - Please restart the Icinga Agent to apply this change
[Notice]: Generating host certificates for host "akw16"
[Notice]: information/base: Writing private key to 'C:\ProgramData\icinga2\var\lib\icinga2\certs\akw16.key'.
information/base: Writing X509 certificate to 'C:\ProgramData\icinga2\var\lib\icinga2\certs\akw16.crt'.
[Notice]: Fetching trusted master certificate from "10.27.0.54"
[Notice]: information/cli: Retrieving TLS certificate for '10.27.0.54:5665'.

 Version:             3
 Subject:             CN = akd
 Issuer:              CN = Icinga CA
 Valid From:          Mar 24 14:09:57 2025 GMT
 Valid Until:         Apr 25 14:09:57 2026 GMT
 Serial:              6b:2f:b8:e6:8d:ec:90:3b:95:56:19:f0:a8:8e:96:38:c7:cc:b1:8c

 Signature Algorithm: sha256WithRSAEncryption
 Subject Alt Names:   akd
 Fingerprint:         9C D9 33 69 F9 9E 3F BC 67 11 75 CA C2 21 03 A7 CE CB D5 ED 10 02 D8 86 A2 1A 0E 41 3B 53 31 E8

***
*** You have to ensure that this certificate actually matches the parent
*** instance's certificate in order to avoid man-in-the-middle attacks.
***

information/pki: Writing certificate to file 'C:\ProgramData\icinga2\var\lib\icinga2\certs\trusted-parent.crt'.
[Notice]: information/cli: Writing CA certificate to file 'C:\ProgramData\icinga2\var\lib\icinga2\certs\ca.crt'.
information/cli: Writing signed certificate to file 'C:\ProgramData\icinga2\var\lib\icinga2\certs\akw16.crt'.
[Notice]: Icinga certificates successfully installed
[Notice]: Icinga Agent zones.conf has been written successfully
[Notice]: Successfully enabled firewall for port "5665"
[Passed]: Icinga Agent service is installed
[Passed]: The specified user "NT Authority\NetworkService" is allowed to run as service
[Passed]: Directory "C:\ProgramData\icinga2\etc" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\ProgramData\icinga2\var" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\cache" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\config" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: Directory "C:\Program Files\WindowsPowerShell\Modules\icinga-powershell-framework\certificate" is accessible and writable by the Icinga Service User "NT Authority\NetworkService"
[Passed]: The Icinga Agent state file does not exist
[Passed]: Icinga Agent configuration is valid
[Passed]: Icinga Agent debug log is disabled
[Notice]: Restarting service "icinga2"
[Notice]: Background daemon Cmdlet "Start-IcingaWindowsRESTApi" has been configured
[Warning]: You have selected to install the Api-Check feature and all required configurations were made. The Icinga for Windows service is however not marked for installation, which will cause this feature to not work.
[Notice]: Successfully enabled service recovery for service "icinga2"
[Notice]: The task "Renew Certificate" has been successfully registered at location "\Icinga\Icinga for Windows\".
[Warning]: The service "icingapowershell" is not installed
[Warning]: The service "icingapowershell" is not installed

@cla-bot cla-bot bot added the cla/signed label Mar 24, 2025
@Al2Klimov
Copy link
Member Author

Al2Klimov commented Mar 24, 2025

Bildschirmfoto 2025-03-24 um 16 11 59

@Al2Klimov Al2Klimov mentioned this pull request Mar 24, 2025
Open
@Al2Klimov Al2Klimov force-pushed the agent_version branch 2 times, most recently from 358d525 to 301455f Compare June 11, 2025 09:40
@Al2Klimov Al2Klimov requested a review from lippserd August 5, 2025 12:15
@Al2Klimov Al2Klimov requested a review from raviks789 October 13, 2025 09:31
raviks789
raviks789 requested changes Oct 15, 2025
View reviewed changes
library/Director/Objects/IcingaHost.php Outdated
Comment on lines 588 to 597
->where('api_key IS NOT NULL')
->query();

$result = self::loadAll($db, $query);
if (count($result) !== 1) {
throw new NotFoundError('Got invalid API key "%s"', $key);
foreach ($query as $row) {
if (hash_equals($row->api_key, $key)) {
return (new static())->setConnection($db)->setDbProperties($row);
}
}

return current($result);
throw new NotFoundError('Got invalid API key "%s"', $key);
Copy link
Collaborator

@raviks789 raviks789 Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not related to the issue, if I understand correctly. Please fix this in a separate PR.

Copy link
Member Author

@Al2Klimov Al2Klimov Oct 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Al2Klimov Al2Klimov mentioned this pull request Oct 15, 2025
Open
@Al2Klimov Al2Klimov requested a review from raviks789 October 15, 2025 11:26
raviks789
raviks789 approved these changes Oct 15, 2025
View reviewed changes
Copy link
Collaborator

@raviks789 raviks789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

lippserd
lippserd approved these changes Dec 3, 2025
View reviewed changes
Copy link
Member

@lippserd lippserd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@raviks789 Please feel free to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lippserd lippserd lippserd approved these changes

@raviks789 raviks789 raviks789 approved these changes

Assignees

No one assigned

Labels

cla/signed ref/IP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Self service: allow to omit the agent version Install no longer works because it can't find version 2.14.2

4 participants

@Al2Klimov @lippserd @raviks789